Speed up rendering for very large data#1
Open
mattmess1221 wants to merge 1 commit intorazorness:masterfrom
Open
Speed up rendering for very large data#1mattmess1221 wants to merge 1 commit intorazorness:masterfrom
mattmess1221 wants to merge 1 commit intorazorness:masterfrom
Conversation
It does this by not rendering properties that aren't opened. It works best when the data is chunked. The test data has 100 chunks with 100 items each. Without this change, it would take 2000ms to render all 10000 properties. With this change, properties are re-rendered when clicked, which takes 30-50ms, which is a huge improvement. It's not perfect, but it's a huge improvement for viewing large amounts of data with heavily nested properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It does this by not rendering properties that aren't opened. It works best when the data is chunked.
The test data has 100 chunks with 100 items each. Without this change, it would take 2000ms to render all 10000 properties. With this change, properties are re-rendered when clicked, which takes 30-50ms, which is a huge improvement.
It's not perfect, but it's a huge improvement for viewing large amounts of data with heavily nested properties.