Add new Red/Green card and power models with Chinese (zhs) localization#1
Open
Add new Red/Green card and power models with Chinese (zhs) localization#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
zhs) localization for all newly added cards and powers so the UI displays correct titles and descriptions.Description
RedBattleTrance,RedBloodForBlood,RedCleave,RedClothesline,RedCombust,RedFireBreathing,RedHeavyBlade,RedMetallicize,RedPummel,RedSearingBlow, andRedShockwave, implementing their damage, power application, draw, multi-hit, exhaust, scaling, and upgrade behaviors.GreenCorpseExplosionwhich appliesPoisonPowerand aGreenCorpseExplosionPowerthat triggers an explosion on death dealing damage equal to the dead creature's max HP to enemies.GreenCorpseExplosionPower,RedCombustPower,RedFireBreathingPower, andRedMetallicizePowerto handle end-of-turn and trigger-based effects such as self-damage + AOE damage, damage on status/cursed draw, and grant block at end of turn.Localization/zhs/cards_green_custom.json,Localization/zhs/cards_red_custom.json,Localization/zhs/powers_green_custom.json, andLocalization/zhs/powers_red_custom.jsonwith titles and descriptions for the new cards and powers.Testing
dotnet buildto verify compilation of new classes and localization resources and the build completed successfully.dotnet testand all tests passed.Codex Task