Fix unsafe lspclient access

[hador]

Fixes #333

[ray-x]

Thanks for the PR. I think I have a slightly different fix for this issue. As we are obsoleting lspconfig. I will remove the if/else check.
Could you check the latest mast to see if the issue fixed? Thanks!

[crisqyxw]

Regrettably, this commit did not work for me. I tried making some changes:

    if default_config == nil then
      default_config = {}
    end

Crude, but it worked(Of course, with an empty config block)

[hador]

Thanks for the PR. I think I have a slightly different fix for this issue. As we are obsoleting lspconfig. I will remove the if/else check. Could you check the latest mast to see if the issue fixed? Thanks!

Makes sense, but yes this issue is still present in the latest master, stack trace:

Error detected while processing BufNewFile Autocommands for "*":
Error executing lua callback: ...rew/Cellar/neovim/0.11.4/share/nvim/runtime/filetype.lua:36: BufNewFile Autocommands for "*"..FileType Autocommands for "*": Vim(append
):Error executing lua callback: vim/shared.lua:0: after the second argument: expected table, got nil
stack traceback:
        [C]: in function 'error'
        vim/shared.lua: in function 'validate'
        vim/shared.lua: in function 'tbl_deep_extend'
        ...er/opt/navigator.lua/lua/navigator/lspclient/clients.lua:266: in function 'lsp_startup'
        ...er/opt/navigator.lua/lua/navigator/lspclient/clients.lua:464: in function 'setup'
        ...er/opt/navigator.lua/lua/navigator/lspclient/clients.lua:509: in function 'on_filetype'
        ...vim/site/pack/packer/opt/navigator.lua/lua/navigator.lua:314: in function <...vim/site/pack/packer/opt/navigator.lua/lua/navigator.lua:313>
        [C]: in function 'nvim_cmd'
        ...rew/Cellar/neovim/0.11.4/share/nvim/runtime/filetype.lua:36: in function <...rew/Cellar/neovim/0.11.4/share/nvim/runtime/filetype.lua:35>
        [C]: in function 'pcall'
        vim/shared.lua: in function <vim/shared.lua:0>
        [C]: in function '_with'
        ...rew/Cellar/neovim/0.11.4/share/nvim/runtime/filetype.lua:35: in function <...rew/Cellar/neovim/0.11.4/share/nvim/runtime/filetype.lua:10>
stack traceback:
        [C]: in function '_with'
        ...rew/Cellar/neovim/0.11.4/share/nvim/runtime/filetype.lua:35: in function <...rew/Cellar/neovim/0.11.4/share/nvim/runtime/filetype.lua:10>

Error executing vim.schedule lua callback: vim/shared.lua:0: after the second argument: expected table, got nil
stack traceback:
        [C]: in function 'error'
        vim/shared.lua: in function 'validate'
        vim/shared.lua: in function 'tbl_deep_extend'
        ...er/opt/navigator.lua/lua/navigator/lspclient/clients.lua:266: in function 'lsp_startup'
        ...er/opt/navigator.lua/lua/navigator/lspclient/clients.lua:464: in function 'setup'
        ...vim/site/pack/packer/opt/navigator.lua/lua/navigator.lua:321: in function ''
        vim/_editor.lua: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

❯ git log HEAD
commit 546982c1e4be3f6b56f0ebe4cd234073565bcadb (HEAD -> master, origin/master, origin/HEAD)
Author: ray-x <rayx.cn@gmail.com>
Date:   Wed Oct 29 11:57:55 2025 +1100

   remove require('lspconfig') as it is obseleted

[hador]

Regrettably, this commit did not work for me. I tried making some changes:

    if default_config == nil then
      default_config = {}
    end

Crude, but it worked(Of course, with an empty config block)

That's strange as the nil case should have been handled in the previous conditional block.

Mind posting the entire stack trace?

[crisqyxw]

Error executing lua callback: /usr/share/nvim/runtime/filetype.lua:36: BufNewFile 自动命令 "*"..FileType 自动命令 "*": Vim(append):Error executing lua callback: vim/shared.lua:0: after the second argument: expected table, got nil
stack traceback:
        [C]: in function 'error'
        vim/shared.lua: in function 'validate'
        vim/shared.lua: in function 'tbl_deep_extend'
        ...m/lazy/navigator.lua/lua/navigator/lspclient/clients.lua:266: in function 'lsp_startup'
        ...m/lazy/navigator.lua/lua/navigator/lspclient/clients.lua:464: in function 'setup'
        ...m/lazy/navigator.lua/lua/navigator/lspclient/clients.lua:509: in function 'on_filetype'
        ...q/.local/share/nvim/lazy/navigator.lua/lua/navigator.lua:314: in function <...q/.local/share/nvim/lazy/navigator.lua/lua/navigator.lua:313>
        [C]: in function 'nvim_cmd'
        /usr/share/nvim/runtime/filetype.lua:36: in function </usr/share/nvim/runtime/filetype.lua:35>
        [C]: in function 'pcall'
        vim/shared.lua: in function <vim/shared.lua:0>
        [C]: in function '_with'
        /usr/share/nvim/runtime/filetype.lua:35: in function </usr/share/nvim/runtime/filetype.lua:10>
stack traceback:
        [C]: in function '_with'
        /usr/share/nvim/runtime/filetype.lua:35: in function </usr/share/nvim/runtime/filetype.lua:10>
Error executing vim.schedule lua callback: vim/shared.lua:0: after the second argument: expected table, got nil
stack traceback:
        [C]: in function 'error'
        vim/shared.lua: in function 'validate'
        vim/shared.lua: in function 'tbl_deep_extend'
        ...m/lazy/navigator.lua/lua/navigator/lspclient/clients.lua:266: in function 'lsp_startup'
        ...m/lazy/navigator.lua/lua/navigator/lspclient/clients.lua:464: in function 'setup'
        ...q/.local/share/nvim/lazy/navigator.lua/lua/navigator.lua:321: in function ''
        vim/_editor.lua: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

The same.

[ray-x]

Sorry, I was meant to commit to master; however, it was pushed to treesitter-main branch
bc957c7

I have redone the commit, and it should work now.

[hador]

It does!
Thanks, closing.