Refactor/separate test suite for daft native runner and daft ray distributed runner #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 13, 2025 21:03
pdames
reviewed
Dec 14, 2025
Member
pdames
left a comment
pdames
left a comment
There was a problem hiding this comment.
Nice! Just recommended a few minor clarifications to the CI/CD step names to make it clear that these changes only apply to the Daft runner, but otherwise this looks good to merge!
Signed-off-by: Patrick Ames <833518+pdames@users.noreply.github.com>
Signed-off-by: Patrick Ames <833518+pdames@users.noreply.github.com>
Signed-off-by: Patrick Ames <833518+pdames@users.noreply.github.com>
Signed-off-by: Patrick Ames <833518+pdames@users.noreply.github.com>
pdames
approved these changes
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #582 by implementing separate CI jobs for native and distributed Daft tests to prevent runner switching conflicts.
Rationale
Tests were failing with DaftError::InternalError Cannot set runner more than once and Ray actor conflicts when mixing native and distributed Daft execution in the same test session.
Changes
CI Configuration (.github/workflows/ci.yml)
Split the single test job into separate native and distributed jobs
Added environment variables for runner configuration
Updated test filtering to exclude integration tests from unit tests
Pytest Configuration (pytest.ini)
Added distributed marker definition
Impact
Native tests run in isolation with native runner
Distributed tests run in isolation with Ray runner
Testing
Native tests run in isolation with native runner
Distributed tests run in isolation with Ray runner
Workflow ran successfully in my fork