[Converter] Commit high watermark of converter processed up to as part of snapshot properties #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of snapshot properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, we persist the latest snapshot id Ray converter processed up to as part of snapshot properties. This snapshot id property serve as the same purpose as high watermark.
Key Changes
1. Snapshot Properties vs Table Properties
sourceSnapshotId,sourceSequenceNumber): Track the input snapshots that were processed by the Ray converter. These represent the "high watermark" of source data that has been converted.Why This Matters: This distinction allows operators to understand both what data was processed (snapshot properties) and what output was generated (table properties), enabling precise incremental processing for CDC usecase and avoiding reprocessing of already-converted data.
Rationale
Explain the reasoning behind the changes and their benefits to the project.
Changes
List the major changes made in this pull request.
Impact
Discuss any potential impacts the changes may have on existing functionalities.
Testing
Describe how the changes have been tested, including both automated and manual testing strategies.
If this is a bugfix, explain how the fix has been tested to ensure the bug is resolved without introducing new issues.
Regression Risk
If this is a bugfix, assess the risk of regression caused by this fix and steps taken to mitigate it.
Checklist
Unit tests covering the changes have been added
E2E testing has been performed
Additional Notes
Any additional information or context relevant to this PR.