Fix false concurrent conflict limit threshold detection between non-concurrent metafile revisions #587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These changes resolve #585 by ensuring that only metafile revisions with the same revision number are counted against DeltaCAT's max concurrent write conflict limit (vs. prior behavior of treating all revisions in a revision directory partition as potential conflicts). All changes required to resolve #585 are in metafile.py, with corresponding tests in test_metafile_io.py.
Other Changes (not directly related to #585):
FYI @IvanPartsunev.
Testing
Wrote failing unit tests and ensured that they passed post-update.
Checklist
Unit tests covering the changes have been added
E2E testing has been performed