Added error code 501 [Not Implemented]#3
Added error code 501 [Not Implemented]#3ravindrapalaskar17 wants to merge 2 commits intoImplement-error-code-501from
Conversation
code/API_definitions/qod-api.yaml
Outdated
| example: | ||
| code: NOT_FOUND | ||
| message: "Session Id does not exist" | ||
| Generic501: |
There was a problem hiding this comment.
The schema is not used ... as the same details are defined already within the response above?
There was a problem hiding this comment.
Yes.. right... I think we can remove this schema...!!! As 501 (NOT_IMPLEMENTED) error code is required only for /sessions not for /get sessions/{sessionId} , /delete session and /notifications
because only in create sessions we required UE identifiers in all other request we required session id which is not UE so we don't need Generic501 schema above 501 response is sufficient....
There was a problem hiding this comment.
Committed code with the changes. Kindly have a look
Removed Generic501 Schema as the same details are defined already within the above response.
| name: Apache 2.0 | ||
| url: https://www.apache.org/licenses/LICENSE-2.0.html | ||
| version: 0.8.0 | ||
| version: 0.9.0 |
There was a problem hiding this comment.
Don't change the version number in the PR, we will define it when releasing a version to be used (most probably this change will go into v0.8.1).
There was a problem hiding this comment.
Ok.. Should I keep 0.8.0 or make it 0.8.1..?
| example: | ||
| code: NOT_FOUND | ||
| message: "Session Id does not exist" | ||
| message: "Session Id does not exist" |
There was a problem hiding this comment.
What is the change here? Is it needed?
There was a problem hiding this comment.
There is No any Changes there. I just removed Generic501 schema from below that line there might be some "Indentation or spaces removed"
There was a problem hiding this comment.
There seem to be 3-4 extra spaces. It cosmetic but would be easy to get rid of them.
2 participants
No description provided.