Open
Conversation
Created Single file for Stable Throughput and latency and Added Necessary changed as per QOD 0.8.0
akoshunyadi
reviewed
Nov 11, 2022
akoshunyadi
left a comment
akoshunyadi
left a comment
There was a problem hiding this comment.
The correct branching for Camara contributions is described here: https://mywiki.confluence.telekom.de/pages/viewpage.action?pageId=1435539866
|
|
||
| **App-Flow** | ||
| Describes the precise flow the developer wants to prioritize and have stable bandwidth/latency for. This flow is described using source and destination IP addresses, ports and protocols with flow direction. | ||
|
|
There was a problem hiding this comment.
This is not correct, the v0.8.0 uses ueId and asId and no protocol.
| # Overview | ||
|
|
||
| <span class="colour" style="color:rgb(0, 0, 0)">The Quality-On-Demand (QoD 0.8.0) API provides programmable interface for developers and other users (capabilities consumers) to specify stable data-transfer throughput/latency managed by Telco networks, without necessity to have in-depth knowledge of the 4G/5G system complexity by abstracting the internal complexity of telecom systems [1].</span> | ||
|
|
There was a problem hiding this comment.
The API version shouldn't be contained in the text, maybe as a extra field.
| | Snippet 1. Create QoS session | | ||
| |-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | curl -X 'POST' `https://sample-base-url/qod/api/v0/sessions` <br> -H 'accept: application/json' <br> -H 'Content-Type: application/json'<br> -H "Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbG...."<br> -d '{<br> "duration": 3600,<br> "ueId": "10.0.0.1",<br> "asId": "54.204.25.0/28",<br> "asPorts": "33001",<br> "qos": "QOS\_L",<br> "notificationUri": `https://your-callback-server.com/notifications` ,<br> "notificationAuthToken": "c8974e592c2fa383d4a3960714"<br> }' | | ||
| <br> |
There was a problem hiding this comment.
parameters are incorrect ueId, asId, asPorts
| | 7 | Forbidden | 403 | "Forbidden to invoke operation" | | ||
| | 8 | Session with same parameters already exists | 409 | "Found session \<session> already active until \<expirationTime>" | | ||
| | 9 | Service unavailable | 503 | “Internal error due to requrired telco service unvailability" | | ||
|
|
There was a problem hiding this comment.
The table should have the columns: HTTP status code, error code, error message. Please check the implementation!
|
|
||
| * QoS session with 1H duration and QoS-profile "L" mapping, | ||
| * App-Flow is specified for UDP protocol with UE-Terminal IP address (ueAddr=10.0.0.1), Application server network (asAddr=54.204.25.0/28) and Port number (asPorts=33001). | ||
|
|
There was a problem hiding this comment.
There is no ueAddr, asAddr, port spec is different, please check the spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added New Image file in resource.