Skip to content

Conversation

@krajcikondra
Copy link

Hi,

on php 8.2 I get errors like this:

Deprecated: Creation of dynamic property Ratchet\Server\IoConnection::$httpBuffer is deprecated

@krajcikondra krajcikondra changed the title fix dynamic properties fix dynamic properties PHP 8.2 Mar 17, 2023
@SimonFrings
Copy link

@krajcikondra The test suite doesn't execute the tests with PHP 8.2 currently and we can't see if your changes are completely fixing the issue, but I am looking into that, see #1003 for more details. Once I get everything updated, we can come back to this one. Depending on how far I go with #1003, I might need to apply the same changes as you did, I'll keep you posted 👍

@PaulRotmann
Copy link
Contributor

Hey! Thanks for this pull request 🙏

As part of our cleanup initiative (#1100), we're closing old PRs that have already been resolved. We've recently merged #1096 which implements the same idea, but turned out to be a bit more involved than initially anticipated.

If you have further improvements to suggest, feel free to open a new pull request. We appreciate your contributions and welcome any future enhancements. If you want to support Ratchet, please consider sponsoring our work! ❤️

Thanks again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants