PHP 8.4: Implicitly nullable parameters deprecated

[valzargaming]

Implicitly marking parameters as nullable is deprecated, the explicit nullable type must be used instead

[danepowell]

@cboden do you mind reviewing this? Do you plan to continue maintaining this project or should we fork it?

[valzargaming]

Another developer has stated they are considering dropping safe altogether as PHPStan is enough. shish/safe also seems to be maintained as an alternative package.

[mbonneau]

@danepowell I will take a look at this PR and ratchetphp/RFC6455#71

Right now, composer has a minimum PHP version at 5.4. Adding the explicit nullable parameter will require a minimum version bump to 7.1.

I have no problem changing the minimum version as long as it is good with @cboden.

[shehi]

Would be great to see some motion here...

[FlisherOfatale]

@danepowell I will take a look at this PR and ratchetphp/RFC6455#71

Right now, composer has a minimum PHP version at 5.4. Adding the explicit nullable parameter will require a minimum version bump to 7.1.

I have no problem changing the minimum version as long as it is good with @cboden.

Conaidering it involve version unsupported for ages, these shouldn't stopped from supporting modern versions.

People stuck many years behind should have locked their old composer file anyway.

[sanmai]

FWIW thecodingmachine/safe is at v3.0.2 now.

[thorewi]

ok @cboden now when there is a new version of https://github.com/ratchetphp/RFC6455, can you please accept this? thank you.

[thorewi]

@valzargaming can you please change ratchet/rfc6455 to 0.4 ?

[thorewi]

@valzargaming can you also merge actual master branch? because now it's crashing due to error

Fatal error: Uncaught ArgumentCountError: Too few arguments to function Ratchet\RFC6455\Handshake\ClientNegotiator::__construct(), 0 passed in /var/www/html/vendor/ratchet/pawl/src/Connector.php on line 28 and at least 1 expected in /var/www/html/vendor/ratchet/rfc6455/src/Handshake/ClientNegotiator.php:15

which was probably fixed here https://github.com/ratchetphp/Pawl/commits/master/

[thorewi]

yep... perfect, seems working like a charm... and even tests passed...

[mbonneau]

Thanks @valzargaming