feat(webgl2): update to beamterm 0.15.0 and add disable_auto_css_resize option
#155
Annotations
10 warnings
|
Run clippy action:
src/backend/utils.rs#L211
warning: used `unwrap()` on an `Option` value
--> src/backend/utils.rs:211:13
|
211 | let s = web_sys::window().unwrap().screen().unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is `None`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unwrap_used
|
|
Run clippy action:
src/backend/utils.rs#L211
warning: used `unwrap()` on a `Result` value
--> src/backend/utils.rs:211:13
|
211 | let s = web_sys::window().unwrap().screen().unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unwrap_used
|
|
Run clippy action:
src/backend/utils.rs#L188
warning: used `unwrap()` on an `Option` value
--> src/backend/utils.rs:188:54
|
188 | let color = ansi_to_rgb(color).unwrap_or_else(|| ansi_to_rgb(fallback_color).unwrap());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is `None`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unwrap_used
|
|
Run clippy action:
src/backend/webgl2.rs#L789
warning: very complex type used. Consider factoring parts into `type` definitions
--> src/backend/webgl2.rs:789:15
|
789 | callback: Rc<RefCell<dyn FnMut(&str)>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
Run clippy action:
src/backend/webgl2.rs#L589
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/backend/webgl2.rs:589:50
|
589 | Self::update_canvas_cursor_style(&self.beamterm.canvas(), is_over);
| ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.beamterm.canvas()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
Run clippy action:
src/backend/dom.rs#L283
warning: this `if` statement can be collapsed
--> src/backend/dom.rs:283:13
|
283 | / if cell.symbol().len() > 1 && cell.symbol().width() == 2 {
284 | | if (cell_position + 1) < self.cells.len() {
285 | | let next_elem = &self.cells[cell_position + 1];
286 | | next_elem.set_inner_html("");
... |
291 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
283 ~ if cell.symbol().len() > 1 && cell.symbol().width() == 2
284 ~ && (cell_position + 1) < self.cells.len() {
285 | let next_elem = &self.cells[cell_position + 1];
...
289 | .map_err(Error::from)?;
290 ~ }
|
|
|
Run clippy action:
src/backend/dom.rs#L47
warning: doc list item overindented
--> src/backend/dom.rs:47:9
|
47 | /// `"_ratzilla_grid"`.
| ^^^^ help: try using ` ` (2 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_overindented_list_items
= note: `#[warn(clippy::doc_overindented_list_items)]` on by default
|
|
Run clippy action:
src/backend/canvas.rs#L408
warning: used `unwrap()` on an `Option` value
--> src/backend/canvas.rs:408:21
|
408 | let color = self.debug_mode.as_ref().unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is `None`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unwrap_used
note: the lint level is defined here
--> src/lib.rs:1:23
|
1 | #![warn(missing_docs, clippy::unwrap_used)]
| ^^^^^^^^^^^^^^^^^^^
|
|
Run clippy action:
src/backend/canvas.rs#L276
warning: doc list item without indentation
--> src/backend/canvas.rs:276:9
|
276 | /// or when `always_clip_cells` is enabled.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
276 | /// or when `always_clip_cells` is enabled.
| +++
|
|
Run clippy action:
src/error.rs#L58
warning: this can be `std::io::Error::other(_)`
--> src/error.rs:58:9
|
58 | std::io::Error::new(std::io::ErrorKind::Other, error.to_string())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#io_other_error
= note: `#[warn(clippy::io_other_error)]` on by default
help: use `std::io::Error::other`
|
58 - std::io::Error::new(std::io::ErrorKind::Other, error.to_string())
58 + std::io::Error::other(error.to_string())
|
|
Loading