Merged
Conversation
privat
reviewed
Jul 2, 2025
Collaborator
privat
left a comment
privat
left a comment
There was a problem hiding this comment.
nice. remove the unrelated useless change. squash the commits to have a nice patch, and I will merge.
src/rars/assembler/Assembler.java
Outdated
| if (statement.getInstruction() instanceof BasicInstruction) { | ||
| //if statement is in .text, add to machineList | ||
| if (Memory.inTextSegment(statement.getAddress())) | ||
| if (Memory.inTextSegment(statement.getAddress())) { |
…ain function with ret
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We wanted to emulate a more realistic compiler (ie gcc with __start that calls main). To do so, we needed to create a fake text segment with pre-built instructions.
When start at main is enabled in the settings, and main is recognized as global :
Fix #115