fix(channels): use correct argument key for tool progress summary (#1357)#1358
Open
fix(channels): use correct argument key for tool progress summary (#1357)#1358
Conversation
… summary (#1357) `tool_arguments_summary` and `tool_display_info` used `arguments.get("path")` but the actual parameter field in read-file/write-file/edit-file is `file_path`. This caused file path summaries to always be empty. Also show summary in CLI TUI for finished tools (not just in-progress), so fast-completing tools like read-file (0ms) still display what was read. Closes #1357
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_arguments_summaryandtool_display_infousing wrong key"path"instead of"file_path"for read-file/write-file/edit-file tools — summary was always empty"file_path"to fallback key lists for unknown toolsType of change
bugComponent
backendCloses
Closes #1357
Test plan
summary_read_file,display_info_read_file,display_info_edit_filetool_displaytests passcargo check/cargo clippy/cargo fmtpass