This repository was archived by the owner on Apr 2, 2026. It is now read-only.
refactor(broker): demote PaperBroker to test-only (#185)#187
Merged
Conversation
…tion paths (#185) - Remove BrokerConfig::Paper variant from account config - Remove paper broker from registry (register_all) - Strip registry_entry/parse_fill_price from paper.rs, keep PaperBroker for tests - Replace hardcoded PaperBroker in daemon with account-config-based broker creation - Remove --broker/--fill-price CLI args, exchange is now required - Update accounts.toml template: default to ccxt sandbox instead of paper - Rename run_paper_trading → run_live_trading - Rename PaperTrading error variant → Trading - Fix irrefutable if-let patterns after Paper variant removal Closes #185
Reject account creation upfront when credentials are missing for live accounts instead of silently defaulting to empty strings. Sandbox accounts still allow omitting credentials since some testnets don't require them. Closes #185
…nology (#185) - Rename Paper command → Trade, PaperAction → TradeAction - Rename all run_paper_* functions → run_trade_* - Rename PaperStatusResponse/PaperStopResponse/PaperShutdownSummary → Trade* - Update all JSON action keys from "paper.*" to "trade.*" - Remove "paper" from setup wizard comments - Update accounts template comments Closes #185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BrokerConfig::Paper— users can no longer configurebroker = "paper"inaccounts.tomlrun_live_tradingcreates broker fromaccounts.tomlinstead of hardcodingPaperBroker--brokerand--fill-priceargs removed;--exchangeis now requiredccxt + sandbox = true(Binance testnet)Paper trading =
CcxtBroker { sandbox: true }against real exchange testnets.Verification
cargo check— clean, zero warningscargo test— 11 tests pass (4 lib + 7 e2e)cargo clippy --all-targets --all-features -- -D warnings— cleanCloses #185