Update CI images workflow to build and push Presto coordinator#274
Open
Avinash-Raj wants to merge 5 commits intomainfrom
Open
Update CI images workflow to build and push Presto coordinator#274Avinash-Raj wants to merge 5 commits intomainfrom
Avinash-Raj wants to merge 5 commits intomainfrom
Conversation
bdice
reviewed
Mar 14, 2026
Contributor
bdice
left a comment
There was a problem hiding this comment.
I think we should split the build and test phases into separate workflows.
The logic for "maybe build, unless I supplied an image name" is not very intuitive.
I recommend that we make ci-images-manual.yml and ci-images-nightly.yml call the build phase, and then they will get an output for the built image names. Then call the test phase.
If you want to add the ability to test with an image name, we can make a manual dispatch for only the test phase.
I recommend that we break this up into a few separate pieces:
- Add the Presto coordinator build & merge steps
- Split the workflows into build & test, with a manual dispatch trigger for the test phase
- Add the integration test jobs to the test phase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.