Skip to content

Update CI images workflow to build and push Presto coordinator#274

Open
Avinash-Raj wants to merge 5 commits intomainfrom
update-ci-images-workflo-to-build-push-presto-coordinator
Open

Update CI images workflow to build and push Presto coordinator#274
Avinash-Raj wants to merge 5 commits intomainfrom
update-ci-images-workflo-to-build-push-presto-coordinator

Conversation

@Avinash-Raj
Copy link
Contributor

No description provided.

@Avinash-Raj Avinash-Raj requested a review from a team as a code owner March 14, 2026 12:25
@bdice bdice changed the title Update ci images workflow to build push presto coordinator Update CI images workflow to build and push Presto coordinator Mar 14, 2026
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split the build and test phases into separate workflows.

The logic for "maybe build, unless I supplied an image name" is not very intuitive.

I recommend that we make ci-images-manual.yml and ci-images-nightly.yml call the build phase, and then they will get an output for the built image names. Then call the test phase.

If you want to add the ability to test with an image name, we can make a manual dispatch for only the test phase.

I recommend that we break this up into a few separate pieces:

  • Add the Presto coordinator build & merge steps
  • Split the workflows into build & test, with a manual dispatch trigger for the test phase
  • Add the integration test jobs to the test phase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants