Draft
Conversation
madsbk
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
madsbk
force-pushed
the
rrun_in_wheels
branch
5 times, most recently
from
e0062db to
1870254
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rrunis bundled in thelibrapidsmpfwheel atlibrapidsmpf/bin/rrunbut was not onPATHafterpip install. This adds a Python shim (librapidsmpf/_rrun.py) and a[project.scripts]entry so pip creates a properrrunwrapper in the environment'sbin/directory, matching the conda behavior.Also adds a smoke test in
ci/test_wheel.shthat verifiesrrunis on PATH after wheel install.