Add logging support to KvikIO using the rapids-logger library#943
Open
kingcrimsontianyu wants to merge 6 commits intorapidsai:mainfrom
Open
Add logging support to KvikIO using the rapids-logger library#943kingcrimsontianyu wants to merge 6 commits intorapidsai:mainfrom
kingcrimsontianyu wants to merge 6 commits intorapidsai:mainfrom
Conversation
kingcrimsontianyu
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
kingcrimsontianyu
changed the title
Contributor
Author
|
/ok to test f42cc18 |
Contributor
Author
|
/ok to test e30780e |
Contributor
Author
|
/ok to test 893a49b |
Contributor
Author
|
/ok to test 386de91 |
Member
|
Sorry, clicked the close bottom while scrolling on my phone 😥 |
| # natively installed library or a conda package, in which case the import will | ||
| # fail and we assume the library is discoverable on system paths. | ||
| pass | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This part follows what libcudf uses: https://github.com/rapidsai/cudf/blob/main/python/libcudf/libcudf/load.py#L36
| extras: | ||
| table: project | ||
| includes: | ||
| - depends_on_rapids_logger |
Contributor
Author
There was a problem hiding this comment.
This part follows what cudf uses: https://github.com/rapidsai/cudf/blob/main/dependencies.yaml#L232
madsbk
approved these changes
Mar 9, 2026
Contributor
Author
|
Thanks @madsbk! I'll wait for the feedback on the build related changes from the build experts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds logging support using the rapids-logger library. Logging is disabled by default and can be enabled through two environment variables:
KVIKIO_LOG_LEVEL:INFOorDEBUG(case-insensitive). Disabled if unset.KVIKIO_LOG_FILE: Optional file path for log output. Falls back to stderr if unset or if the file cannot be opened.