xfail test_sizeof_cudf
#1602
Merged
xfail test_sizeof_cudf
#1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After rapidsai/cudf#20961, `test_sizeof_cudf` is failing. This adds an xfail marker while we come up with a longer-term plan for how to handle this properly. There are a few issues at play here: cudf is in the midst of refactoring some things that are pretty sensitive to the implementation. We don't want to be this sensitive to the internal buffers used by some column. This test is also testing some proxying / spilling mechanism. cudf is in the midst of implementing an improved version of that. dask-cuda should use that where possible. Finally, we don't import dask-cudf, which registers the custom `sizeof` for cudf objects, so some of the sizeof computations were off to being with. Overall, xfailing for now seems reasonable.
quasiben
approved these changes
Jan 6, 2026
Contributor
Author
|
/merge |
wence-
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After rapidsai/cudf#20961,
test_sizeof_cudfis failing. This adds an xfail marker while we come up with a longer-term plan for how to handle this properly.There are a few issues at play here: cudf is in the midst of refactoring some things that are pretty sensitive to the implementation. We don't want to be this sensitive to the internal buffers used by some column.
This test is also testing some proxying / spilling mechanism. cudf is in the midst of implementing an improved version of that. dask-cuda should use that where possible.
Finally, we don't import dask-cudf, which registers the custom
sizeoffor cudf objects, so some of the sizeof computations were off to being with. Overall, xfailing for now seems reasonable.