Modernize the uses of raft in cuVS#1837
Merged
rapids-bot[bot] merged 11 commits intorapidsai:mainfrom Feb 25, 2026
Merged
Conversation
dantegd
approved these changes
Feb 23, 2026
Co-authored-by: Dante Gama Dessavre <dante.gamadessavre@gmail.com>
tarang-jain
reviewed
Feb 24, 2026
Contributor
tarang-jain
left a comment
There was a problem hiding this comment.
Thanks for the meticulous effort! A bunch of comments from my end.
Contributor
Author
|
Thanks @tarang-jain for the suggestions! all addressed |
divyegala
previously requested changes
Feb 24, 2026
Member
divyegala
left a comment
There was a problem hiding this comment.
The FAISS patch should be created in a new file for 26.04.
tarang-jain
reviewed
Feb 25, 2026
94713e2 to
f8fb4d7
Compare
Contributor
Author
|
/merge |
tfeher
pushed a commit
to Stardust-SJF/cuvs_rabitq
that referenced
this pull request
Mar 3, 2026
A non-breaking src-only changes to modernize the use of raft primitives across cuVS source code. The general rule applied here is to prefer raft helpers taking `raft::resources` as an argument over other raft helpers over third-party libraries. - thrust::fill / thrust::fill_n → raft::matrix::fill - thrust::transform → raft::linalg::map - thrust::sequence / thrust::tabulate → raft::linalg::map_offset - raft::linalg::unaryOp / raft::linalg::binaryOp → raft::linalg::map - raft::linalg::add (pointer-based) → raft::linalg::add (mdspan-based) - raft::copy (pointer-based) → raft::copy (mdspan-based) - raft::update_device / raft::update_host → raft::copy (mdspan-based) - raft::linalg::rowNorm → raft::linalg::norm - raft::linalg::reduce (pointer-based) → raft::linalg::reduce (mdspan-based) - cudaMemsetAsync → raft::matrix::fill The purpose of this PR is to improve the consistency in using the library code (even though sometimes at the cost of a bit more auxiliary code). This is also a prerequisite to achieving dry run compliance in cuVS if we choose to merge that in rapidsai/raft#2961 Authors: - Artem M. Chirkin (https://github.com/achirkin) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#1837
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A non-breaking src-only changes to modernize the use of raft primitives across cuVS source code. The general rule applied here is to prefer raft helpers taking
raft::resourcesas an argument over other raft helpers over third-party libraries.The purpose of this PR is to improve the consistency in using the library code (even though sometimes at the cost of a bit more auxiliary code).
This is also a prerequisite to achieving dry run compliance in cuVS if we choose to merge that in rapidsai/raft#2961