Skip to content

Enable collation of all license files into pre-built binaries #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
robertmaynard wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable collation of all license files into pre-built binaries #1679

robertmaynard wants to merge 2 commits into from
+9 −6

Conversation

@robertmaynard
Copy link
Contributor

@robertmaynard robertmaynard commented Jan 7, 2026

No description provided.

@robertmaynard robertmaynard added the feature request New feature or request label Jan 7, 2026
@robertmaynard robertmaynard added the non-breaking Introduces a non-breaking change label Jan 7, 2026
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 7, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@robertmaynard
Copy link
Contributor Author

robertmaynard commented Jan 7, 2026

/okay to test

@robertmaynard robertmaynard force-pushed the fea/add_spdx_license_builder_to_ci_jobs branch from 6e69111 to c64c622 Compare January 7, 2026 19:03
@robertmaynard
Copy link
Contributor Author

robertmaynard commented Jan 7, 2026

/okay to test

@robertmaynard robertmaynard force-pushed the fea/add_spdx_license_builder_to_ci_jobs branch from c64c622 to 77b4bd8 Compare January 7, 2026 20:10
@robertmaynard
Copy link
Contributor Author

robertmaynard commented Jan 7, 2026

/okay to test

@robertmaynard robertmaynard force-pushed the fea/add_spdx_license_builder_to_ci_jobs branch from 77b4bd8 to 9484455 Compare January 7, 2026 20:11
@robertmaynard
Copy link
Contributor Author

robertmaynard commented Jan 7, 2026

/okay to test

@robertmaynard robertmaynard marked this pull request as ready for review January 7, 2026 21:14
@robertmaynard robertmaynard requested a review from a team as a code owner January 7, 2026 21:14
@robertmaynard robertmaynard requested a review from msarahan January 7, 2026 21:14
@robertmaynard robertmaynard mentioned this pull request Jan 7, 2026
Merged
@robertmaynard
Copy link
Contributor Author

robertmaynard commented Jan 7, 2026

Waiting on rapidsai/shared-workflows#488 before we can merge

@robertmaynard robertmaynard force-pushed the fea/add_spdx_license_builder_to_ci_jobs branch from 9484455 to a143845 Compare January 8, 2026 14:53
@robertmaynard robertmaynard force-pushed the fea/add_spdx_license_builder_to_ci_jobs branch from a143845 to 4a0897b Compare January 8, 2026 17:28
msarahan
msarahan reviewed Jan 8, 2026
View reviewed changes
ci/build_standalone_c.sh
cat SPDX_FRAGMENT_LICENSE_FILES >> c/build/install/LICENSE

python ./tool/find_and_copy_license_files.py "." > DEP_LICENSE_FILES
cat DEP_LICENSE_FILES >> c/build/install/LICENSE
Copy link
Contributor

@msarahan msarahan Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you concerned about duplicating any entries here? Should this be more of an update operation than an append?

Why not have the python script do the output handling directly? If it's just a matter of not wanting to deal with python, I can help you.

Copy link
Contributor Author

@robertmaynard robertmaynard Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you concerned about duplicating any entries here? Should this be more of an update operation than an append?

I wrote it this way so that if you needed to run the build locally you could see which tool added each line to the mega license file. We could have the python script pipe directly to c/build/install/LICENSE if we wanted instead.

Why not have the python script do the output handling directly? If it's just a matter of not wanting to deal with python, I can help you.

Yes. Happy to have help if we want to have python append/write to explicitly provided files instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msarahan msarahan msarahan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

feature request New feature or request non-breaking Introduces a non-breaking change

Projects

Vector Search, ML, & Data Mining Release Board
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robertmaynard @msarahan