export all type-defintions #73
Conversation
+ some unrelated tweaks
|
|
||
| export class LocationConflation { | ||
| private _cache: Map<string, GeoJSONFeature>; | ||
| public _cache: Map<string, GeoJSONFeature>; |
There was a problem hiding this comment.
this property is used by iD and Rapid. Not sure if it's better to mark it as public, or keep it private and add a new helper method instead? (for manually inserting into the cache)
There was a problem hiding this comment.
Ah yeah this surprised me too when I updated Rapid's LocationConflation recently
bhousel/Rapid@869a453
I forgot that we were inserting things directly into the cache. I agree that making it public is fine for now, and sometime soon add some helpers/tests/docs for cache management and to make it clearer that it's allowed to be used that way.
| "version": "2.0.0", | ||
| "license": "ISC", | ||
| "repository": "github:rapideditor/location-conflation", | ||
| "repository": "https://github.com/rapideditor/location-conflation", |
There was a problem hiding this comment.
despite the npm docs allowing this syntax, the npm website doesn't allow it.... Therefore, the link from the npm package to the git repo no longer works
There was a problem hiding this comment.
Ugh, thanks for letting me know. I didnt realize npm did this.
|
Thanks! sorry I missed the |
2 participants
exported all
interfaces andtypes, so that consumers can access them.There's a few other unimportant things in this PR, which could be removed. see comments below: