This repository was archived by the owner on Mar 4, 2024. It is now read-only.
Make Expand JSON an optional feature, as originally requested. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix help message for adduser
* user id changed to user key * version bump
* refactoring - better error handling * version bump
lecli/cli.py
Outdated
| """Query logs using LEQL""" | ||
|
|
||
| print "expand: ", | ||
| print expand |
Author
|
Hows that? |
Contributor
|
LGTM |
Contributor
|
Sorry forgot to mention documentation, I think we should add a few lines for this in README.md file. |
Contributor
|
Hey @durzo, any updates on this? If you can document this feature with a few sentences, then we can push this through. |
stopal-r7
force-pushed
the
master
branch
2 times, most recently
from
47b1fed to
97164ba
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #17 I asked for Expand JSON to be optional, twice. it was instead put in by default and the issue was closed. this broke our output parsing by CI tools so I fixed it in this commit.
Expand JSON is now turned on by passing -e or --expand to any of the 'query', 'events' or 'recentevents' commands otherwise it defaults to off.