-
Notifications
You must be signed in to change notification settings - Fork 43
Py23 compatibility #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Py23 compatibility #41
Conversation
|
RE: README As I mention, I rather prefer the motivation/details for the first few sentences in the README. I re-implemented some of the previous old README sentences, as it gives an explanation of Classic HotNet and HotNet2. Is it clean to users given the README what RE: C/Fortran In principle, users should compile these extensions when installing the python package, similar to WExT. I haven't dealt with this. I don't think it is very important for the use case. I've kept RE: py23 compatibility changes --- Any --- We were previously using implicit relative imports. Python does not like this----these need to be explicit relative imports --- https://github.com/raphael-group/hotnet2/blob/master/scripts/permuteNetwork.py#L70 I actually think this was a bug. Even in Python2.7, this should be I should note that variations of this line of code are used at every instance of multiprocessing, but we don't explicitly check for --- Tuple parameters to functions is not allowed in Python3.x. I unpack the tuples within the function, which is both 2.7 and 3.x compatible. e.g. https://github.com/evanbiederstedt/hotnet2/blob/master/hotnet2/permutations.py#L13-L14 --- The largest change is the work around for https://github.com/evanbiederstedt/hotnet2/blob/master/hotnet2/hnio.py#L391-L455 I save the HDF5 as type |
Compatibility with both 2.7 and 3.x.
Encoding/decoding strings in order to bypass this issue: h5py/h5py#289
Revisions to travis config, README, style changes