Check that the class is actually a user#255
Open
stafflink-web-services wants to merge 1 commit intorankmath:masterfrom
Open
Conversation
Adds a check before getting the user meta_type and ensuring it's a user before proceeding with the user. In some instances, Rank Math is catching a custom post type if other plugins are involved. For example, sometimes the post object is being fed into the class-user, and this object does not have a 'meta_type', causing a fatal error in PHP 8+.
mattneal-stafflink
approved these changes
Nov 7, 2023
|
Cancel this one. I'm an idiot. One of my devs were doing something super small but super silly, so I went on a long path trying to fix something that wasn't broken. Ignore this request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check before getting the user meta_type and ensuring it's a user before proceeding with the user.
In some instances, Rank Math is catching a custom post type if other plugins are involved. For example, sometimes the post object is being fed into the class-user, and this object does not have a 'meta_type', causing a fatal error in PHP 8+.