Leverage the new script API strategy feature to defer front end scripts#253
Open
adamsilverstein wants to merge 1 commit intorankmath:masterfrom
Open
Leverage the new script API strategy feature to defer front end scripts#253adamsilverstein wants to merge 1 commit intorankmath:masterfrom
adamsilverstein wants to merge 1 commit intorankmath:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
deferattribute to the front end scriptjs/rank-math.jsenqueued inincludes/frontend/class-frontend.php.Context
WordPress introduced a new strategy feature in the Script API in version 6.3. See this post for more details. Even though
js/rank-math.jsis only enqueued when the wp-admin bar is shown, it still seems helpful to leveragedeferand switch away from the booleanin_footersetting.Note that this PR includes a version check and slightly different behavior for 6.3 vs. 6.4 where a potential regression is fixed.
Summary
Test instructions
data-wp-strategy="deferindicating the API has added the attribute.