Fix teensy-resid crash and compile issues for Pi0#303
Open
aminch wants to merge 1 commit intorandyrossi:masterfrom
Open
Fix teensy-resid crash and compile issues for Pi0#303aminch wants to merge 1 commit intorandyrossi:masterfrom
aminch wants to merge 1 commit intorandyrossi:masterfrom
Conversation
* Fix teensy-resid compile issues and start up crash for Pi0 * Run autogen for vice everytime * Add script to easily rest repo to a clean state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to build for Pi Zero (Pi0) I ran into compile problems, and then a crash on start up. Proposed pull request for this issue: #302
The compile issues were related to the missing types and redundant header which I updated to the siddefs.h header in teensy-resid so that the changes only affected that module and Pi0 build. Adding these fixed the compile problems.
I also updated the make_all.sh to build the teensy-resid during a build for Pi0 as that was missing, and added a call to the autogen.sh for vice to make it easier to compile from a clean repo.
Once it compiled I got a crash on startup which is shown in the log in this issue: #302
This turned out to be a problem with the return of the call from set_sampling_parameters when it was called from resid.cc line 253, into the built teensy-resid library. It was missing the return value, which caused the startup crash.
I added a seprate script reset_repo.sh as a simple way to reset all the repo and submodule back to a clean state, to make it easier to test building from a directly checked out respository. Not needed in the pull request but I found it nice to have.