Update kernel.cpp for C128 extra keys in C128 mode.#240
Update kernel.cpp for C128 extra keys in C128 mode.#240nickgoodmanuk wants to merge 41 commits intorandyrossi:masterfrom
Conversation
Added extra keys for real Commodore 128 keyboard. randyrossi#201
nickgoodmanuk
changed the title
|
I will make a build with these changes in and put it up as a test build in
a directory on my site. Can you ping me if you don't hear back from me in
a couple days? I'm consumed by work right now but I will try to do this so
you can test the changes. Then we can merge this in and do a release.
…On Tue, Aug 22, 2023 at 6:27 AM Nick Goodman ***@***.***> wrote:
Added my proposed change for the Commodore 128 keyboards extra keys, as
discussed in issue 201. This is untested as I was not able build my own
kernal.
#201 <#201>
------------------------------
You can view, comment on, or merge this pull request online at:
#240
Commit Summary
- a04ba19
<a04ba19>
Update kernel.cpp
File Changes
(1 file <https://github.com/randyrossi/bmc64/pull/240/files>)
- *M* kernel.cpp
<https://github.com/randyrossi/bmc64/pull/240/files#diff-ae7f4f762ab6d2b0e2a54523d05a4721701684cb34e39e98bd32e29eeb045417>
(11)
Patch Links:
- https://github.com/randyrossi/bmc64/pull/240.patch
- https://github.com/randyrossi/bmc64/pull/240.diff
—
Reply to this email directly, view it on GitHub
<#240>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI3HKCULTZQTPXZSHT2XY3XWSCQNANCNFSM6AAAAAA3ZWBXW4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Randy Rossi
- "There are only two things that are hard about computer science; Naming
things, Cache Invalidation, and Off-by-one errors."
|
|
> I will make a build with these changes in and put it up as a test build in a directory on my site. Can you ping me if you don't hear back from me in a couple days? I'm consumed by work right now but I will try to do this so you can test the changes. Then we can merge this in and do a release. Will do, Thankyou. I know you are very busy, as am I haven't had chance to address it further until now. I appreciate it. |
|
@randyrossi Gentle reminder about a test build. No rush :) |
randyrossi
left a comment
randyrossi
left a comment
There was a problem hiding this comment.
Please see review comments.
kernel.cpp
Outdated
| {KEYCODE_F5, KEYCODE_e, KEYCODE_t, KEYCODE_u, KEYCODE_o, KEYCODE_LeftBracket, KEYCODE_Equals, KEYCODE_q}, | ||
| {KEYCODE_Insert, KEYCODE_LeftShift, KEYCODE_x, KEYCODE_v, KEYCODE_n, KEYCODE_Comma, KEYCODE_Slash, KEYCODE_Escape}, | ||
| }; | ||
| #else if defined(RASPI_C128) |
There was a problem hiding this comment.
This should be #elif defined(RASPI_C128)
Fails to compile as-is. I'll fix locally for a build but please change before I merge this in.
kernel.cpp
Outdated
| {KEYCODE_Insert, KEYCODE_LeftShift, KEYCODE_x, KEYCODE_v, KEYCODE_n, KEYCODE_Comma, KEYCODE_Slash, KEYCODE_Escape}, | ||
| }; | ||
| #else if defined(RASPI_C128) | ||
| static long kbdMatrixKeyCodes[11][8] = { |
There was a problem hiding this comment.
These dimensions are backwards from the data provided. Also, if the dimension is going to change then the kbdPA iterator later on in this file would have to change to 0->10 but it is still only 0-7. Then the gpioPins array would also have to be adjusted for the scan to actually include the extra 3 pins. gpioPins[8] and gpioPins[9] and gpioPins[10] would have to become the three new PA lines. Then the remaining would have to shift up. I don't think this change is sufficient to do what you want it to do. There would be more work elsewhere and a bunch of conditionals to extend the PA lines only for the C128 builds.
There was a problem hiding this comment.
Thanks ever so much for looking. I will try and fix based on your comments.
|
Please see the review comments. The change won't work as you expect.
There is additional work to do with the gpio lines.
…On Thu, Aug 31, 2023 at 4:27 AM Nick Goodman ***@***.***> wrote:
@randyrossi <https://github.com/randyrossi> Gentle reminder about a test
build. No rush :)
—
Reply to this email directly, view it on GitHub
<#240 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI3HKABJDXTETX2HFXDLBLXYBDGTANCNFSM6AAAAAA3ZWBXW4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Randy Rossi
- "There are only two things that are hard about computer science; Naming
things, Cache Invalidation, and Off-by-one errors."
|
|
Changes made to pull request now I have been able to build myself. |
2 participants
Added my proposed change for the Commodore 128 keyboards extra keys, as discussed in issue 201. This is untested as I was not able build my own kernal.
#201