Skip to content

Signing Complete #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vivekteega wants to merge 3 commits into
base: standard_ops
Choose a base branch
from
Open

Signing Complete #2

vivekteega wants to merge 3 commits into from

Conversation

@vivekteega
Copy link
Member

@vivekteega vivekteega commented Jul 9, 2022

No description provided.

@vivekteega vivekteega closed this Jul 9, 2022
@vivekteega vivekteega reopened this Jul 9, 2022
@vivekteega vivekteega closed this Jul 9, 2022
@vivekteega
Copy link
Member Author

vivekteega commented Jul 9, 2022

Pulling Tanishk changes into branch "standard-operations" for further revision

The sign_message functions now verifies with standard operations.
Things to note:
The function now takes 2 parameters -

Message in string ( not hex-encoded string)
Private key in wif (not bytes etc.)
the hex parameter has been removed as we are always returning hex in standard ops
New libraries used - hashlib
The elliptical curve folder, holds the code taken from starkbank ecdsa (MIT License)
no other additional dependencies

@vivekteega vivekteega reopened this Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vivekteega @legion2002