Add support to configure GKE Network Policies #3949
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westlywright
approved these changes
May 8, 2020
Contributor
westlywright
left a comment
westlywright
left a comment
There was a problem hiding this comment.
@bashofmann LG2M, I am going to hold merging this until the backend bug is merged as well so we dont have another bug opened in QA. Nope, we only directly edit the English and simplified Chinese translations in this repo, other translations are managed via CrowdIn Rancher
Contributor
|
Closing PR due to age and un-merged backend. Feel free to reopen if backend changes are merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds an additional flag when creating GKE clusters to enable/disable NetworkPolicy support in GKE. This is already possible with the API, but not exposed in the UI.
Types of changes
Since it is present in the API, I'd consider this a bugfix.
Linked Issues
rancher/rancher#26918
Further comments
There is currently an issue in the kontainer-engine. Even though the flag is set in the API, it is not configured correctly on the GKE side: rancher/rancher#26917. Addressed in rancher/kontainer-engine#225.
I'm not quite sure, if I also have to add non-english translations, or what the process is here.