-
Notifications
You must be signed in to change notification settings - Fork 35
Bump Cluster API to v1.11.4 #2003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
26f54b0 to
b9ebb6d
Compare
fa3c0c3 to
b7b0744
Compare
salasberryfin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @furkatgofurov7! Overall looks good to me.
|
@salasberryfin thanks for review, I addressed all your concerns and suggestions in 8faa02e |
8faa02e to
c7b93d1
Compare
salasberryfin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can probably disable any RKE2-related E2E tests since they'll be failing until the provider version is bumped to a v1.11 compatible release (not yet ready 😓).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect this to be broken until a new CAPRKE2 release with support for CAPI v1.11 is out, and then we'll have to add some extra changes to the templates.
23981b4 to
a35b066
Compare
…ing CAPI v1.11.x Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
a35b066 to
b23030b
Compare
| controlPlane: | ||
| metadata: {} | ||
| replicas: ${CONTROL_PLANE_MACHINE_COUNT} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| controlPlane: | |
| replicas: ${CONTROL_PLANE_MACHINE_COUNT} |
While working on CAPRKE2 I noticed that topology.controlPlane.metadata can no longer be empty and thought I'd share it here. We'll probably need to remove it from here.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: