add new tag `pit.harvester.daily` for recurring harvester runs #463

slickwarren · 2026-01-22T22:48:29Z

also added scripts to fall back on if the 'build server' goes down

validation/harvester/provisioning/cloud_provider_test.go

validation/longhorn/chartinstall/installation_test.go

lscalabrini01

Overall, it looks good. I just have a few comments

validation/harvester/provisioning/cloud_provider_test.go

hamistao · 2026-01-23T16:48:13Z

validation/harvester/provisioning/cloud_provider_test.go

+
+	p.cattleConfig = config.LoadConfigFromFile(os.Getenv(config.ConfigEnvironmentKey))
+
+	p.cattleConfig, err = defaults.SetK8sDefault(client, defaults.RKE2, p.cattleConfig)


is the k8s version configurable?

yes, its still pulled from the config file. But if it shows up as empty, SetK8sDefault will use the latest (which is what I want in this case, but the config value is still used as 1st priority if it is there)

hamistao · 2026-01-23T16:49:27Z

validation/harvester/provisioning/cloud_provider_test.go

+	nodeRolesDedicated := []provisioninginput.MachinePools{provisioninginput.EtcdMachinePool, provisioninginput.ControlPlaneMachinePool, provisioninginput.WorkerMachinePool}
+	nodeRolesDedicated[0].MachinePoolConfig.Quantity = 1
+	nodeRolesDedicated[1].MachinePoolConfig.Quantity = 2
+	nodeRolesDedicated[2].MachinePoolConfig.Quantity = 2


So this means 1 etcd, 2 control plane and 2 worker? why not the more standard 1 etcd, 1 control plane and 2 worker?

for cloud provider, the cpi controller runs on the control plane. having 2 cp nodes is the 'production minimum' recommendation (we usually do 3etcd, 2cp, 3 workers but I'm resource limited in harvester lab)

Potential future enhancement to allow this to be set via config as well, but I'm fine with the hardcoded values right now due to our lab limitations.

validation/harvester/provisioning/cloud_provider_test.go

hamistao · 2026-01-23T17:29:46Z

@slickwarren Also just alerting that a PR check is failing due to:

  validation/harvester/provisioning/cloud_provider_test.go:29:1: File is not properly formatted (goimports)
  	client             *rancher.Client
  ^

floatingman

Just a few bash suggestions

floatingman · 2026-01-23T19:21:09Z

scripts/build_and_serve_harvester_images/build-harvester-image.sh

@@ -0,0 +1,45 @@
+#!/bin/bash
+


Added a set -eu so this script quits if there is an error, otherwise it will continue to run, which could cause problems with all of the creating and deleting going on.

floatingman · 2026-01-23T19:23:27Z

scripts/build_and_serve_harvester_images/setup-harvester-dev-build.sh

+# harvester has a heavy dependency on v28 and below of docker for now. 
+sudo apt install -y docker-ce=5:28.5.2-1~ubuntu.24.04~noble docker-ce-cli=5:28.5.2-1~ubuntu.24.04~noble containerd.io
+
+sudo usermod -aG docker ubuntu


Change ubuntu to $USER in case the user running this script changes. For example, if we ever change to using SUSE Linux vs. Ubuntu

floatingman · 2026-01-23T19:28:27Z

scripts/build_and_serve_harvester_images/build-harvester-image.sh

+# can run make before-hand, but I don't think its necessary if I just want images. . 
+# make 
+make build-iso
+sleep 10


Why is this sleep necessary?

sometimes, the file write at the last stage isn't quite complete for some reason after make build-iso which caused a timing issue on the next step.

floatingman · 2026-01-23T19:31:53Z

scripts/build_and_serve_harvester_images/setup-harvester-dev-build.sh

+
+rm -rf /usr/local/go && tar -C /usr/local -xzf go1.25.5.linux-amd64.tar.gz
+
+echo "export PATH=$PATH:/usr/local/go/bin" >> .bashrc


Change this to single quotes. Changes the way the $PATH variable is expanded, preventing issues that are hard to diagnose.

floatingman · 2026-01-23T19:33:53Z

scripts/build_and_serve_harvester_images/files.conf

+    listen [::]:32309;
+    server_name _;
+
+    root /home/ubuntu/harvester/dist/artifacts;


You might want to add a comment here about changing the path if we ever change the linux distribution this is run on.

floatingman · 2026-01-23T19:36:48Z

scripts/build_and_serve_harvester_images/build-harvester-image.sh

+rm -rf old/
+rm -rf latest/


You probably want to check if these directories exist first before deleting them.
Something like this is sufficient

if [ -d "$DIRECTORY" ]; then echo "$DIRECTORY does exist." fi

this is actually why I don't set -eu 😅 good suggestion

floatingman · 2026-01-23T19:46:42Z

scripts/build_and_serve_harvester_images/setup-harvester-dev-build.sh

@@ -0,0 +1,36 @@
+#!/bin/bash
+


Add a set -eu here too.

lscalabrini01 · 2026-01-23T21:18:38Z

validation/harvester/provisioning/cloud_provider_test.go

-		logrus.Infof("Provisioning cluster")
-		cluster, err := provisioning.CreateProvisioningCluster(tt.client, provider, credentialSpec, clusterConfig, machineConfigSpec, nil)
-		require.NoError(p.T(), err)
+	logrus.Infof("Provisioning cluster")


nit: could you use the suite approche for the logs on the tests?

suggestion: p.T().Logf("Provisioning cluster")

we usually use logrus for logs

lscalabrini01 · 2026-01-23T21:19:21Z

validation/harvester/provisioning/cloud_provider_test.go

 }

-func (p *HarvesterProvisioningTestSuite) TestHarvesterCloudProvider() {
+func (p *HarvesterProvisioningTestSuite) TestCloudProvider() {


nit: could we 'h' as suite variable?

I wanted p for provisioning 😄

slickwarren · 2026-01-23T21:35:42Z

@floatingman the scripts are in a 'beta' state if you will. But they're all currently used and working on the server node. I just wanted to add them here as a fallback -- Can I make a separate ticket to address your comments for it and merge as-is?

rancher-max · 2026-01-23T22:16:33Z

validation/harvester/provisioning/cloud_provider_test.go

+	nodeRolesDedicated := []provisioninginput.MachinePools{provisioninginput.EtcdMachinePool, provisioninginput.ControlPlaneMachinePool, provisioninginput.WorkerMachinePool}
+	nodeRolesDedicated[0].MachinePoolConfig.Quantity = 1
+	nodeRolesDedicated[1].MachinePoolConfig.Quantity = 2
+	nodeRolesDedicated[2].MachinePoolConfig.Quantity = 2


Potential future enhancement to allow this to be set via config as well, but I'm fine with the hardcoded values right now due to our lab limitations.

removed from this PR

github-actions added 2 commits January 22, 2026 11:32

adding || pit.harvester.daily tag to relevant tests

40cc425

init commit; instructions + scripts for building harvester ISOs

4a58b3c

slickwarren requested a review from a team as a code owner January 22, 2026 22:48

slickwarren added the team/pit-crew slack notifier for pit crew label Jan 22, 2026

lscalabrini01 reviewed Jan 23, 2026

View reviewed changes

validation/harvester/provisioning/cloud_provider_test.go Outdated Show resolved Hide resolved

lscalabrini01 reviewed Jan 23, 2026

View reviewed changes

validation/harvester/provisioning/cloud_provider_test.go Outdated Show resolved Hide resolved

lscalabrini01 reviewed Jan 23, 2026

View reviewed changes

validation/harvester/provisioning/cloud_provider_test.go Outdated Show resolved Hide resolved

lscalabrini01 reviewed Jan 23, 2026

View reviewed changes

validation/longhorn/chartinstall/installation_test.go Show resolved Hide resolved

lscalabrini01 reviewed Jan 23, 2026

View reviewed changes

validation/harvester/provisioning/cloud_provider_test.go Show resolved Hide resolved

floatingman self-requested a review January 23, 2026 17:12

slickwarren requested review from a team and lscalabrini01 January 23, 2026 17:23

hamistao reviewed Jan 23, 2026

View reviewed changes

adjusting schema; rm'd unnecessary variables

3cc7323

slickwarren force-pushed the cwarren/harvester-tests-v1 branch from e3c0c72 to 3cc7323 Compare January 23, 2026 18:40

This was referenced Jan 23, 2026

build harvester (dev version) nightly rancher/qa-tasks#2142

Open

select + setup tests for nightly harvester runs rancher/qa-tasks#2127

Open

floatingman previously requested changes Jan 23, 2026

View reviewed changes

lscalabrini01 reviewed Jan 23, 2026

View reviewed changes

slickwarren requested review from floatingman and hamistao January 23, 2026 21:38

reverting harvester build scripts

3110e68

rancher-max approved these changes Jan 23, 2026

View reviewed changes

slickwarren merged commit 3a410cd into rancher:main Jan 23, 2026
3 checks passed

slickwarren deleted the cwarren/harvester-tests-v1 branch January 23, 2026 22:31


		p.cattleConfig = config.LoadConfigFromFile(os.Getenv(config.ConfigEnvironmentKey))

		p.cattleConfig, err = defaults.SetK8sDefault(client, defaults.RKE2, p.cattleConfig)


		rm -rf /usr/local/go && tar -C /usr/local -xzf go1.25.5.linux-amd64.tar.gz

		echo "export PATH=$PATH:/usr/local/go/bin" >> .bashrc

add new tag pit.harvester.daily for recurring harvester runs #463

add new tag pit.harvester.daily for recurring harvester runs #463

Uh oh!

Conversation

slickwarren commented Jan 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lscalabrini01 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hamistao commented Jan 23, 2026

Uh oh!

floatingman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

slickwarren commented Jan 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

add new tag `pit.harvester.daily` for recurring harvester runs #463

add new tag `pit.harvester.daily` for recurring harvester runs #463

lscalabrini01 left a comment •

edited

Loading