Skip to content

Fix potential panic in observeDeletedObjectAfterFinalize where recentDeletions could be nil #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crobby merged 2 commits into from
Jun 23, 2025
Merged

Fix potential panic in observeDeletedObjectAfterFinalize where recentDeletions could be nil #165

crobby merged 2 commits into from
Jun 23, 2025

Conversation

@crobby
Copy link
Contributor

@crobby crobby commented Jun 23, 2025

Another follow-up from #160 to fix a panic discovered when updating webhook

@crobby crobby requested a review from a team as a code owner June 23, 2025 19:50
@crobby crobby requested review from a team and aruiz14 and removed request for a team June 23, 2025 19:51
@crobby crobby merged commit 0e3b207 into rancher:main Jun 23, 2025
1 check passed
@aruiz14
Copy link
Contributor

aruiz14 commented Jun 24, 2025

Thanks @crobby!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohitsakala rohitsakala rohitsakala approved these changes

@gehrkefc gehrkefc gehrkefc approved these changes

@aruiz14 aruiz14 Awaiting requested review from aruiz14

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crobby @aruiz14 @rohitsakala @gehrkefc