Fix WaitForAllPods and bump backup-restore-operator#1760
Merged
Conversation
Uses operator v9.0.1 for Rancher v2.13 and v2.14 Signed-off-by: Loic Devulder <ldevulder@suse.com>
We should check for all status at once and not pod by pod. Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
github-project-automation
bot
moved this from 👀 Needs review
to 🏃🏼♂️ In Progress
in Elemental
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recently added
WaitForAllPodsfunction sporadically fails: this is because the list of pods list is created and then the status checked but meanwhile some pod changed.This PR fix this by checking pods/ status at once. The PR also outputted pods' status to allow better debugging.
Backup-restore operator is also bumped to v9.0.1 and this version is also used for Rancher Manager v2.14.