Adding a troubleshooting and verification page in docs#488
Adding a troubleshooting and verification page in docs#488davidcassany merged 1 commit intorancher:mainfrom
Conversation
✅ Deploy Preview for elemental-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
frelon
left a comment
frelon
left a comment
There was a problem hiding this comment.
Nice work! If you also want it to show up as a link in the sidebar you need to add it in sidebar.js file.
davidcassany
left a comment
davidcassany
left a comment
There was a problem hiding this comment.
Thanks @Gagrio! I think we are almost good to go. I'd also update the docs to versions 1.8 and 1.7 with the same changes. That is the files under versioned_docs/version-1.8 and versioned_docs/version-1.7 respectively. I'd say we are ready to merge after updating those two versions 👍
|
I haven't squashed any commits so far, please @davidcassany let me know if that's alright. Should I "squash and merge" via github button on you want me to actually make everything in one commit before merging? |
|
Looks good! Just missing the sidebars for each version, see Yes, I'd squash all comits before merging, even we are not following a strict policy in that regard. |
|
Added the sidebars for the 1.7 and 1.8 versions. I will squash commits when all looks good, before merging. Edit: I can see the sidebars now for next, 1.8 and 1.7 versions: https://deploy-preview-488--elemental-docs-staging.netlify.app/troubleshooting-verification |
Gagrio
force-pushed
the
troubleshooting-verification
branch
from
5dca3f6 to
c0f32d8
Compare
|
squashed commits |
Gagrio
force-pushed
the
troubleshooting-verification
branch
from
23878ec to
aba9100
Compare
Gagrio
force-pushed
the
troubleshooting-verification
branch
from
aba9100 to
7f90ecd
Compare
davidcassany
left a comment
davidcassany
left a comment
There was a problem hiding this comment.
Thanks @Gagrio Looks good to me 👍
3 participants
No description provided.