Parameterize render sanitization + Deep general sanitization #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markets
reviewed
Oct 20, 2025
| } | ||
|
|
||
| // For primitives (numbers, booleans, etc.), return as-is | ||
| return data |
Member
There was a problem hiding this comment.
@araluce maybe we should move here too this code block still in templates?
// Handle null and undefined values in output by replacing them with empty string
if (typeof output === 'string') {
return output.replace(/\bnull\b/g, '').replace(/\bundefined\b/g, '')
}
markets
reviewed
Oct 20, 2025
| insertTemplate(query, template, data, position = null) { | ||
| const html = render(template, data) | ||
| insertTemplate(query, template, data, options = {}) { | ||
| const defaults = { sanitize: true } |
Member
There was a problem hiding this comment.
The original idea of this method is to use with "sanitize false", as we only need to sanitize data, the template is controlled by us. Otherwise I'm not sure if this method makes sense 🤔?
In general, I'd like to keep Ralix rendering as safe as possible by default, but at the same time we need to provide good ergonomics to work with the framework (passing "sanitize false" seems like an exception).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes in this request:
insertHTMLandrenderhelpers.