Open
Conversation
subtlepseudonym
approved these changes
Feb 25, 2022
Contributor
subtlepseudonym
left a comment
subtlepseudonym
left a comment
There was a problem hiding this comment.
Looks good to me!
I do have the same nitpick about the commit message formatting, but it's not a blocker. For example, something like the message below better fits convention:
Update install instructions to use "go install"
The use of "go get" for installing go executables is deprecated as of
version 1.17: https://go.dev/doc/go-get-install-deprecation
The use of "go get" for installing go executables is deprecated as of version 1.17: https://go.dev/doc/go-get-install-deprecation
jonasbn
force-pushed
the
install_docs
branch
from
0306d54 to
64489da
Compare
|
lgtm! |
|
Just had the same issue. i can confirm go install works :) |
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated installation documentation based on the deprecation of
go getfor executables with Go version 1.17REF: https://go.dev/doc/go-get-install-deprecation