Vaultless Phase 5: Webapp Order Detail Display #2415
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findolor
force-pushed
the
2026-01-21-vaultless-phase-4-webapp-order-creation-ui
branch
from
c63f528 to
2520c89
Compare
findolor
force-pushed
the
2026-01-21-vaultless-phase-5-webapp-order-detail
branch
from
efe9473 to
c875f1e
Compare
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
findolor
force-pushed
the
2026-01-21-vaultless-phase-4-webapp-order-creation-ui
branch
from
2520c89 to
36e34fa
Compare
- Add vaultless: bool field derived from vault_id == 0 - Replace AccountBalance and RaindexVaultAllowance with unified RaindexAmount - RaindexAmount has amount (Float) and formattedAmount (String) - getAllowance returns "Unlimited" for max allowance values - Add tests for vaultless field behavior
- Create VaultlessTokenDisplay for order detail vaultless tokens - Fetches wallet balance and allowance via TanStack Query - Shows blue badge, wallet balance, and approved amount - Update VaultCard to show vaultless badge without balance/link - Add tests for vaultless vault rendering
- Conditionally render VaultlessTokenDisplay for vaultless vaults - Hide deposit/withdraw buttons for vaultless tokens
- Replace AccountBalance with RaindexAmount type - Update field references: balance -> amount, formattedBalance -> formattedAmount
Check for max U256 allowance before attempting Float conversion to avoid LossyConversionToFloat error in vaultless token display.
- Update gui.test.ts to use amount/formattedAmount fields - Reposition vaultless badge in VaultCard with absolute positioning - Update rain.strategies commit hash in webapp and tauri
getAllowance and getOwnerBalance now return RaindexAmount with amount (Float) and formattedAmount (String) fields instead of raw hex strings.
…into 2026-01-21-vaultless-phase-5-webapp-order-detail
findolor
force-pushed
the
2026-01-21-vaultless-phase-5-webapp-order-detail
branch
from
c875f1e to
94ece61
Compare
…eld names Update mock responses to use correct field names (amount/formattedAmount) instead of deprecated balance/formattedBalance fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chained PRs
Motivation
See issues:
Phase 5 of the vaultless orders implementation. Updates the webapp order detail page to properly display vaultless tokens which use vault_id = 0 to indicate direct wallet-based trading rather than vault-based.
Solution
Core Changes
vaultlessfield toRaindexVaultto distinguish wallet-based from vault-based tokensRaindexAmounttype across rust and js_api for consistent balance/allowance representationVaultlessTokenDisplaycomponent for rendering vaultless tokens with wallet balance and allowance infoOrder Detail Updates
OrderDetail.sveltenow detects vaultless tokens and renders them differentlyVaultCard.svelteupdated to handle vaultless tokens - hides deposit/withdraw buttons and shows wallet infoModal Updates
DepositModal.svelteandWithdrawModal.svelteupdated to work withRaindexAmounttypeTesting
VaultlessTokenDisplay.test.tswith comprehensive test coverageVaultCard.test.tsfor vaultless behaviorTokenIOInput.test.tstestsChecks
By submitting this for review, I'm confirming I've done the following:
fix #2407