Take orders V6 SDK implementation

[findolor]

Chained PRs

• wip on exact swap #2366

Motivation

See issues:

• Implement Take Orders SDK with V6 Exact Swap Interface #2386
• Take Orders SDK Functionality #2353
• Take Orders SDK – Phase 3: Exact‑In Simulation and Builder #2357

This is the V6 implementation of the take orders SDK, replacing the V5 version from #2360.

The V6 interface (from #2366) provides better exact swap support with minimumIO, maximumIO, and maximumIORatio parameters, enabling four distinct trading modes: buy exact, buy up to, spend exact, and spend up to.

Solution

SDK Layer (crates/common/src/take_orders/)

Modular SDK for take orders simulation and config building:

• candidates.rs - Build TakeOrderCandidate from orders with concurrent quote fetching
• simulation.rs - Simulate buy/spend modes over candidates with price-cap filtering
• config.rs - TakeOrdersMode enum and TakeOrdersConfigV5 building
• price.rs - Float comparison utilities

API Layer (crates/common/src/raindex_client/take_orders/)

Public API for generating takeOrders4 calldata:

• get_take_orders_calldata - Main entry point that fetches orders, simulates, and returns calldata
• request.rs - Input parsing and validation
• selection.rs - Cross-orderbook simulation and best-yield selection
• result.rs - Calldata result with pricing info (effective price, per-leg prices, max sell cap)

Key Features

• Four trading modes: buyExact, buyUpTo, spendExact, spendUpTo
• Cross-orderbook optimization: Selects the orderbook with best yield
• Price cap enforcement: Filters orders exceeding the specified price limit
• Comprehensive testing: 111 tests covering unit and e2e scenarios

Checks

By submitting this for review, I'm confirming I've done the following:

• made this PR as small as possible
• unit-tested any new functionality
• linked any relevant issues or PRs
• included screenshots (if this involves a front-end change)

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[findolor]

Code review

Found 1 issue:

1. Inaccurate documentation for maxSellCap - doc says amount * priceCap but this formula only applies to buy modes. For spend modes, max_sell_cap is just amount (no multiplication by price cap).

Documentation states:

/// - `maxSellCap`: `amount * priceCap` (worst-case on-chain spend cap).

But implementation shows mode-dependent behavior:

let max_sell_cap = if mode.is_buy_mode() {
    mode.target_amount().mul(price_cap)?  // buy: amount * priceCap
} else {
    mode.target_amount()  // spend: just amount
};

rain.orderbook/crates/common/src/raindex_client/take_orders/mod.rs

Lines 59 to 61 in f42c905

	/// - `expectedSell`: simulated sell at current quotes.
	/// - `maxSellCap`: `amount * priceCap` (worst-case on-chain spend cap).
	///

rain.orderbook/crates/common/src/raindex_client/take_orders/result.rs

Lines 59 to 65 in f42c905

	let expected_sell = built_config.sim.total_input;
	let max_sell_cap = if mode.is_buy_mode() {
	mode.target_amount().mul(price_cap)?
	} else {
	mode.target_amount()
	};

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}