fix nix ci

[thedavidmeister]

Motivation

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

• made this PR as small as possible
• unit-tested any new functionality
• linked any relevant issues or PRs
• included screenshots (if this involves a front-end change)

Summary by CodeRabbit

• Chores

  • Updated continuous integration workflow for improved Nix installation and caching.
  • Updated subproject references for dependencies.
  • Set the EVM version to "paris" in the configuration.

• Tests

  • Added external view wrapper functions to enhance testability of data contract reading functions.
  • Improved consistency in test variable naming.

[coderabbitai]

Walkthrough

The updates include changes to the Rainix CI GitHub Actions workflow for improved Nix installation and caching, a configuration update in foundry.toml to specify the EVM version, submodule reference updates for forge-std and rain.solmem, and enhancements to the DataContractTest contract to enable external testing of library read functions.

Changes

File(s)	Change Summary
.github/workflows/rainix.yaml	Updated Nix installation and caching steps in CI workflow; replaced setup actions and added store cache.
foundry.toml	Added evm_version = "paris" to the default profile.
lib/forge-std, lib/rain.solmem	Updated submodule commit references.
test/lib/LibDataContract.t.sol	Added external view wrappers for library read functions; updated tests to use these wrappers.

Sequence Diagram(s)

sequenceDiagram
    participant TestRunner
    participant DataContractTest
    participant LibDataContract

    TestRunner->>DataContractTest: readExternal(address)
    DataContractTest->>LibDataContract: read(address)
    LibDataContract-->>DataContractTest: bytes
    DataContractTest-->>TestRunner: bytes

    TestRunner->>DataContractTest: readSliceExternal(address, start, length)
    DataContractTest->>LibDataContract: readSlice(address, start, length)
    LibDataContract-->>DataContractTest: bytes
    DataContractTest-->>TestRunner: bytes

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7faea17 and c98776f.

⛔ Files ignored due to path filters (1)

• flake.lock is excluded by !**/*.lock

📒 Files selected for processing (5)

• .github/workflows/rainix.yaml (1 hunks)
• foundry.toml (1 hunks)
• lib/forge-std (1 hunks)
• lib/rain.solmem (1 hunks)
• test/lib/LibDataContract.t.sol (4 hunks)

🧰 Additional context used

🪛 GitHub Actions: Rainix CI

test/lib/LibDataContract.t.sol

[error] 1-1: Test failure in DataContractTest::testZoltu(): vm.createSelectFork failed to instantiate forked environment due to unauthorized RPC request. Error code -32000: Unauthorized: You must authenticate your request with an API key. Create an account on https://www.ankr.com/rpc/ and generate your personal API key for free.

🔇 Additional comments (8)

lib/forge-std (1)

1-1:

Details

✅ Verification successful

Verify updated forge-std submodule commit
Ensure that the pinned commit f46d8301cf732f4f83846565aa475628265e51e0 exists in the remote and that the submodule builds correctly under the updated Nix CI setup.

Run the following script to validate:

---

🏁 Script executed:

#!/bin/bash
# Description: Validate that the forge-std submodule is at the intended commit
git submodule update --init lib/forge-std
pushd lib/forge-std > /dev/null
current=$(git rev-parse HEAD)
if [ "$current" != "f46d8301cf732f4f83846565aa475628265e51e0" ]; then
  echo "❌ Unexpected submodule HEAD: $current"
  exit 1
fi
echo "✅ forge-std submodule is at the correct commit."
popd > /dev/null

Length of output: 651

---

forge-std submodule commit verified

The pinned commit f46d8301cf732f4f83846565aa475628265e51e0 has been fetched and is correctly checked out under lib/forge-std.
✅ lib/forge-std HEAD is at f46d8301cf732f4f83846565aa475628265e51e0

lib/rain.solmem (1)

1-1: Verify submodule commit hash validity
The rain.solmem submodule pointer has been bumped to 314af4305303204e94fbee80e7e220d1569c45bb. Please confirm that this commit exists in the upstream repository and that the CI workflow pulls and checks out the updated submodule correctly (e.g., via git submodule update --init --recursive).

foundry.toml (1)

9-9: LGTM - Valid EVM version configuration.

The addition of evm_version = "paris" is a valid configuration that specifies the Ethereum Virtual Machine version for compilation and testing. The "paris" version is compatible with Solidity 0.8.25 and provides a consistent compilation target.

.github/workflows/rainix.yaml (1)

20-35: Excellent CI improvements for Nix setup.

The replacement of the Nix installation and caching approach addresses the PR objective of fixing the Nix CI. Key improvements:

1. Updated Nix installer: nixbuild/nix-quick-install-action@v30 with proper configuration for keeping derivations and outputs
2. Enhanced caching: nix-community/cache-nix-action@v6 with smart cache key strategy based on .nix and flake.lock files
3. Resource management: Garbage collection limit (1GB) prevents cache bloat

The cache key strategy using file hashes ensures cache invalidation when dependencies change, while the restore prefixes provide fallback caching.

test/lib/LibDataContract.t.sol (4)

20-30: External wrapper functions for library testing.

The addition of readExternal and readSliceExternal wrapper functions enables testing of library functions via external calls. This is useful for testing different call contexts and error handling behaviors between internal and external invocations.

---

54-66: Proper external call testing with error handling.

The modification to use this.readExternal() instead of direct LibDataContract.read() enables testing the function in an external call context. The explicit reference to the unused read variable (line 66) is a common pattern to avoid compiler warnings about unused return values.

---

91-91: Good variable naming consistency.

The change from datacontract_ to datacontract improves naming consistency throughout the codebase.

---

94-95: Consistent external call pattern implementation.

Similar to the previous test modification, this change uses the external wrapper readSliceExternal for testing library functions in external call context. The unused variable reference follows the same pattern for compiler warning avoidance.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.