Skip to content

Conversation

@islue
Copy link

@islue islue commented Mar 10, 2023

No description provided.

@islue
Copy link
Author

islue commented Jul 4, 2023

Any feedback?

seanpdoyle added a commit to seanpdoyle/activeresource that referenced this pull request Jan 5, 2025
Closes rails#391

Expand the data broadcast by the `request.active_resource` Active
Support Notification instrumentation event.

For `GET` and `OPTION` requests, omit the `:body` value from the
payload. For all other requests, include the `:body`.
@seanpdoyle
Copy link
Contributor

As a complement to this proposal, I've also opened #413. It includes both body and headers, as well as test coverage for the broadcasted events.

seanpdoyle added a commit to seanpdoyle/activeresource that referenced this pull request Jan 5, 2025
Closes rails#391

Expand the data broadcast by the `request.active_resource` Active
Support Notification instrumentation event.

For `GET` and `OPTION` requests, omit the `:body` value from the
payload. For all other requests, include the `:body`.
seanpdoyle added a commit to seanpdoyle/activeresource that referenced this pull request Jan 5, 2025
Closes rails#391

Expand the data broadcast by the `request.active_resource` Active
Support Notification instrumentation event.

For `GET` and `OPTION` requests, omit the `:body` value from the
payload. For all other requests, include the `:body`.
@islue
Copy link
Author

islue commented Jan 5, 2025

cc @byroot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants