Release v3.4.1 #338
Merged
Release v3.4.1 #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add RELEASING.md documenting the gem release process Documents the full release workflow including: - Version bumping - PR flow (development → main) - Automated publish via gem-publish.yml - GitHub Release creation - Branch sync after release - Troubleshooting common issues 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Add context7.json to claim library on Context7 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Use explicit --delete syntax for git push in docs More readable than the colon syntax. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…337) * Add multi-database rake task enhancement for Rails 7+ When a Rails app has multiple databases configured in database.yml, Rails 7+ creates namespaced rake tasks like `db:migrate:primary` and `db:rollback:primary`. Previously, Apartment only enhanced base tasks (`db:migrate`, `db:rollback`), so tenant schemas weren't migrated when using namespaced tasks. This change automatically detects databases with `database_tasks: true` and enhances their namespaced tasks to invoke the corresponding apartment task: - `db:migrate:primary` -> `apartment:migrate` - `db:rollback:primary` -> `apartment:rollback` - `db:migrate:up:primary` -> `apartment:migrate:up` - `db:migrate:down:primary` -> `apartment:migrate:down` - `db:migrate:redo:primary` -> `apartment:migrate:redo` Replica databases and databases with `database_tasks: false` are excluded from enhancement. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Fix connection pool isolation in migrator Wrap migration operations with `with_connection` to pin a single database connection for the entire operation. This ensures that `Tenant.switch` sets `search_path` on the same connection used by `migration_context`. Without this fix, the connection pool may return different connections for the tenant switch vs the actual migration, causing migrations to run against the wrong schema. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Add specs for connection pool isolation in migrator Verifies that `with_connection` is called to pin a single connection for the entire migration operation, ensuring search_path consistency. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Refactor specs to fix RSpec/MultipleMemoizedHelpers Inline config doubles instead of using shared let blocks to reduce memoized helper count below the limit of 5. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Bump version to 3.4.1 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
- Coverage 84.40% 82.01% -2.40%
==========================================
Files 36 36
Lines 994 1034 +40
==========================================
+ Hits 839 848 +9
- Misses 155 186 +31 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v3.4.1
Bug Fixes
Fix multi-database rake task enhancement for Rails 7+: When a Rails app has multiple databases configured, Rails 7+ creates namespaced rake tasks (
db:migrate:primary,db:rollback:primary, etc.). Apartment now automatically detects databases withdatabase_tasks: trueand enhances their namespaced tasks to invoke the corresponding apartment task.Fix connection pool isolation in migrator: Wrap migration operations with
with_connectionto pin a single database connection for the entire operation. This ensuresTenant.switchsetssearch_pathon the same connection used bymigration_context, preventing migrations from running against the wrong schema.Changes
lib/apartment/tasks/enhancements.rb- Added multi-database supportlib/apartment/migrator.rb- Added connection pinningspec/unit/rake_task_enhancer_spec.rb- New tests (19 examples)spec/unit/migrator_spec.rb- Added connection pinning tests (3 examples)🤖 Generated with Claude Code