-
Notifications
You must be signed in to change notification settings - Fork 3
About medicare component created #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…eature/about_dinar
…eature/about_dinar
| "lint": "next lint", | ||
| "lint:fix": "prettier --write ." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why need to use others packages when you can fix it with command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried but I donno why the commands that you gave me aren't working
| <div> | ||
| <AboutUs /> | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use arrow and don't keep unnecessary code on codebase please do like this:
const AboutUss = () => <AboutUs> export default AboutUss
| @@ -2,7 +2,7 @@ import AboutUs from "@/components/AboutUs/AboutUs"; | |||
|
|
|||
| const AboutUss = () => { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the page name give a meaningful name of the page, Like AboutUsPage
| import AppButton from "@/UI/AppButton"; | ||
| import ComponentHeader from "@/UI/ComponentHeader"; | ||
| import Image from "next/image"; | ||
| import { useState } from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import the useState hooks at top.
| <Image | ||
| width={400} | ||
| height={500} | ||
| src="/assets/about_mdc.png" | ||
| alt="Doctor" | ||
| className="rounded-lg w-full" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add lazy loading and quality in image component for better optimization.
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| fill="white" | ||
| viewBox="0 0 24 24" | ||
| strokeWidth="1.5" | ||
| stroke="currentColor" | ||
| className="w-10 h-10" | ||
| > | ||
| <path | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| d="M6.75 12l7.5-4.5v9l-7.5-4.5z" | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the svg file on customSvg folder on the code base and import it from there.
|
|
||
| {/* Right Section*/} | ||
| <div className="w-full md:w-1/2 space-y-5"> | ||
| <ComponentHeader title={"About Medicare"} titleClasses="text-start text-20" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use it like this way: <ComponentHeader title="About Medicare" titleClasses="text-start text-20" />
| originated in the 16th century. Lorem Ipsum is composed in a pseudo-Latin language. | ||
| </p> | ||
| <AppButton | ||
| text={"Read More"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont use curly braches use it like this way: text="Read More"
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| fill="none" | ||
| viewBox="0 0 24 24" | ||
| strokeWidth="1.5" | ||
| stroke="currentColor" | ||
| className="w-6 h-6" | ||
| > | ||
| <path strokeLinecap="round" strokeLinejoin="round" d="M6 18L18 6M6 6l12 12" /> | ||
| </svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the svg file on customSvg folder on the code base and import it from there.
| title={"Our Medical Services"} | ||
| desc={"Prompt and reliable care for emergencies, treatments, and consultations."} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont use curly braches when passing something through props
No description provided.