Fix invalid MP3 output by converting HLS segments with ffmpeg#17
Merged
rahaaatul merged 2 commits intorahaaatul:mainfrom Mar 14, 2026
Merged
Fix invalid MP3 output by converting HLS segments with ffmpeg#17rahaaatul merged 2 commits intorahaaatul:mainfrom
rahaaatul merged 2 commits intorahaaatul:mainfrom
Conversation
ad4f164 to
4ae8de8
Compare
rahaaatul
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HLS audio segments were being concatenated directly into a file with a
.mp3extension.This results in files that:
Although
ffmpegis required by the application, it was not being used for the final audio encoding step.Root Cause
The download logic writes raw HLS transport stream segments directly into a file named
.mp3, without container conversion or audio encoding.Fix
.tsfileffmpegto convert the.tsinto a proper MP3 (MPEG Audio Layer III).tsfile after successful conversionVerification
Verified using:
ffprobe→ confirmscodec_long_name=MP3 (MPEG audio layer 3)This ensures generated files are valid MP3s and align with the requirement that ffmpeg is installed.