Updated sum2 to use Xs instead of Xd #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sum2 in line 52 was referencing x_d[d], though for the second summation in Equation 32 in http://codalism.com/research/papers/wmz10_tois.pdf the authors use Xs, so changing to x_d[s] also, module won't run as __main__, changing call to RBO to score to fix.
louis-cl
approved these changes
Aug 29, 2017
|
Hi @ragrawal , wondering if you can merge this and validate? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sum2 in line 52 was referencing x_d[d], though for the second summation in Equation 32 in http://codalism.com/research/papers/wmz10_tois.pdf the authors use Xs, so changing to x_d[s]
also, module won't run as main, changing call to RBO to score to fix.