Skip to content

Feature 84: Show confirmation before discarding unsaved Expense/Income #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MiguelAcostaDelVecchio wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feature 84: Show confirmation before discarding unsaved Expense/Income #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion app/dime/Views/TransactionView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,9 @@ struct TransactionView: View {
@State var isEditingDecimal = false
@State var decimalValuesAssigned: AssignedDecimal = .none
@State private var priceString: String = "0"

// Discard Changes Confirmation Dialog
@State private var showDiscardChangesDialog: Bool = false

var body: some View {
GeometryReader { proxy in
Expand Down Expand Up @@ -301,7 +304,11 @@ struct TransactionView: View {
.overlay {
HStack {
Button {
dismiss()
if price != 0 || note.isEmpty == false {
showDiscardChangesDialog = true
} else {
dismiss()
}
} label: {
Image(systemName: "xmark")
// .font(.system(size: 16, weight: .semibold))
Copy link
Copy Markdown

@krunalRupyz krunalRupyz Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this commented-out code if it is not required in the future

Expand Down Expand Up @@ -925,6 +932,15 @@ struct TransactionView: View {
swipingOffset = capsuleWidth
}
}
.confirmationDialog("Are you sure you want to discard your changes?", isPresented: $showDiscardChangesDialog) {
Button(role: .destructive) {
dismiss()
} label: {
Text("Discard Changes")
}
} message: {
Text("This action will discard any unsaved changes.")
}
}

func isDateToday(date: Date) -> Bool {
Expand Down