Notebook fixes #59
Merged
Notebook fixes #59
+2,598
−2,591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2026
rafaelpadilla
approved these changes
Feb 2, 2026
Owner
rafaelpadilla
left a comment
rafaelpadilla
left a comment
There was a problem hiding this comment.
Nice! Thank you for your contribution.
When PR #58 is reviewed and approved, we need to include all notebooks in the NB_DIR path.
Owner
There was a problem hiding this comment.
Nice! 👍
I like keeping the nb tests in a different file, apart from our github (branch/PR) workflow, since it takes a while to process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request, I confirm that I have read and fully accept and agree with one of the Petrobras' Contributor License Agreements (CLAs):
Our CLAs are based on the Apache Software Foundation's CLAs:
Some notebooks were failing due to the updated logic for label assignment we pushed previously;
This PR fixes the old notebooks (compliant with v2.0.0/v2.1.0), and also adds a new script, ./bin/nb_test, that automatically executes all notebooks inside ./docs/notebooks, and will fail unless all notebooks can be successfully executed.
I see now that my implementation may conflict with #58, so maybe we clarify how new notebooks will be organized so we may adjust this script accordingly.
As of now, the automated execution is not mapped to our github actions, as it might take a while to execute them all, but we can at least make sure that it passes before pushing changes to the main repo.