Adding script to check git status of Radix DLT Java repos#6
Adding script to check git status of Radix DLT Java repos#6Sajjon wants to merge 1 commit intorc/1.0-beta.11from
Conversation
clstrfsck
left a comment
clstrfsck
left a comment
There was a problem hiding this comment.
Looks good, but could be made more robust by making the script runnable when pwd != scriptdir.
| # co-co-co-combo breaker! | ||
| RADIXDLT_REGRESSION_TESTS_NAME_OF_REPO_AND_ASSUMED_NAME_OF_DIRECTORY='RadixRegressionTests' | ||
|
|
||
| # Arguments: |
There was a problem hiding this comment.
Would be good if this script worked, even if it was not run with the current directory the same as the the script directory, eg ./scripts/radix_git_status.sh
You could use scriptdir=$(dirname "$0") to work out where the script directory was relative to the working directory it was run from.
There was a problem hiding this comment.
nice! fixed! would be nice to get it working even when using symlinks, but readlink -f does not work on macOS 🤷♂️
Sajjon
force-pushed
the
infra/bash_script_git_status_of_radix_repos
branch
from
7ad9518 to
1cdaec7
Compare
|
@clstrfsck fixed your comments :) |
|
Kudos, SonarCloud Quality Gate passed!
|
| for radix_java_repo_path in "${radix_java_repos[@]}" | ||
| do | ||
| git_repo_name=$(basename $radix_java_repo_path) | ||
| if [[ "$git_repo_name" == ".." ]]; then |
There was a problem hiding this comment.
@clstrfsck do you have a solution for this? the dir $RADIXDLT_JAVA_COMMON_PATH contains "..", and thus when calling basename, it will resolve the name .. which is not what I want. I check manpage for basename but did not find any suitable argument....
2 participants
No description provided.