-
Notifications
You must be signed in to change notification settings - Fork 81
rather professional readme document #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @zhaochenyang20, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly updates the project's Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant and professional overhaul of the README.md file. The new version is much better structured, more visually appealing, and provides a clearer and more comprehensive overview of the Miles project. The added sections on model support and the reorganized key features are particularly helpful. I've identified a few minor issues, including a typo and some broken links, which I've detailed in the comments. Overall, this is an excellent update that greatly improves the project's documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| ### 🛡️ Eliminating Train-Inference Mismatch | ||
|
|
||
| ## Recent Updates | ||
| * **Bit-Wise Identical Truly On-Policy**: System-level solution achieving deterministic forward/backward passes through kernel-level optimization (FlashAttention-3, DeepGEMM). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Ying also mentioned a few times that truly on-policy is a bit confusing. Shall we change the name a bit? Say "Bit-wise identical training and inference alignment"?
| | **Qwen** | **Qwen 2, 2.5, 3** | | ||
| | **Llama** | **Llama 3, 3.1, 3.3, 4** | | ||
| | **Gemma** | **Gemma 2, 3, 3N** | | ||
| | **Others** | **Mistral, Mixtral, Phi, gpt-oss and any model supported by SGLang and Megatron** | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we be a bit more explicit and comprehensive? Say at least we know GLM 4.5, 4.6, 4.7 are supported. What about Minimax M2 / M2.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"any model supported by SGLang and Megatron" maybe we shall also add FSDP here? But also we need to mention that FSDP is still experimental. It may be unstable etc.
| --true-on-policy-mode \ | ||
| --rollout-batch-size 512 \ | ||
| --n-samples-per-prompt 8 | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For here is it possible to use a megatron based backend rather than fsdp? Given that fsdp is still a bit experimental and may have some memory issues.
Also at some point we shall say we support both FSDP2 and Megatron training backend, but the FSDP backend is still under development and experimental?
No description provided.