-
Notifications
You must be signed in to change notification settings - Fork 81
Code style guidance and PR template #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @zhaochenyang20, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces foundational documentation to enhance code quality and streamline the development workflow. It establishes a clear pull request template to standardize submission information and provides a comprehensive code style guide to ensure consistency, performance, and maintainability across the codebase. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a pull request template and a code style guide, which are great additions for standardizing contributions. My review focuses on improving the correctness of links in the PR template and minor formatting issues in the code style guide. Specifically, the relative links in the PR template are likely broken and need to be adjusted to be relative to the repository root. Additionally, the code style guide has a minor trailing whitespace issue and is missing a final newline character.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@PopSoda2002 needs your comments |
PopSoda2002
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work! I think there are still some style should be added in the future, stay tunned
PopSoda2002
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added additional examples to the 'Avoid Dynamic Attributes' guideline for clarity.
Added a second example link for abstract base classes in the architecture section.
Clarified the access permission indicator guideline and removed unnecessary comments from the PR section.
| - [ ] Tests pass locally | ||
| - [ ] Documentation updated (if applicable) | ||
| - [ ] Type hints added for public APIs | ||
| - [ ] No unnecessary synchronization calls in hot paths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I know what is hot paths exactly?
As titled. Following our rules.