build(deps): remove testify replace, bump go to 1.25.7#11177
Merged
DariuszPorowski merged 3 commits intomainfrom Feb 6, 2026
Merged
build(deps): remove testify replace, bump go to 1.25.7#11177DariuszPorowski merged 3 commits intomainfrom
DariuszPorowski merged 3 commits intomainfrom
Conversation
DariuszPorowski
requested a deployment
to
external-contributor-approval
GitHub Actions
Waiting
DariuszPorowski
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
6 tasks
sylvainsf
added a commit
that referenced
this pull request
Feb 5, 2026
The approval-gate job was incorrectly requiring approval for PRs from org members (like PR #11177 from DariuszPorowski). Root cause: The conditional environment expression evaluated to an empty string '' for trusted users. However, GitHub Actions treats an empty string as a valid environment reference (creating an empty-named environment), NOT as 'skip using an environment'. Fix: Skip the approval-gate job entirely for trusted users via the 'if' condition, rather than using a conditional environment. Update the setup job to also allow needs.approval-gate.result == 'skipped' so downstream jobs proceed correctly. Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
12 tasks
DariuszPorowski
pushed a commit
that referenced
this pull request
Feb 5, 2026
…11189) # Description Fix the approval-gate job in functional-test-cloud.yaml that was incorrectly gating PRs from org members (like PR #11177 from DariuszPorowski). **Root cause:** The expression `environment: ${{ <condition> && '' || 'external-contributor-approval' }}` evaluates to an empty string `''` for trusted users. However, GitHub Actions treats an empty string as a valid environment reference (creating an empty-named environment), NOT as "skip using an environment." **Fix:** Changed the approach to skip the `approval-gate` job entirely for trusted users via `if` condition, rather than using a conditional environment. Updated the `setup` job to also allow `needs.approval-gate.result == 'skipped'` so downstream jobs proceed correctly. ## Type of change - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and does not change the functionality of Radius (issue link optional). ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: - An overview of proposed schema changes is included in a linked GitHub issue. - [ ] Yes <!-- TaskRadio schema --> - [x] Not applicable <!-- TaskRadio schema --> - A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [ ] Yes <!-- TaskRadio design-pr --> - [x] Not applicable <!-- TaskRadio design-pr --> - The design document has been reviewed and approved by Radius maintainers/approvers. - [ ] Yes <!-- TaskRadio design-review --> - [x] Not applicable <!-- TaskRadio design-review --> - A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] Yes <!-- TaskRadio samples-pr --> - [x] Not applicable <!-- TaskRadio samples-pr --> - A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] Yes <!-- TaskRadio docs-pr --> - [x] Not applicable <!-- TaskRadio docs-pr --> - A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. - [ ] Yes <!-- TaskRadio recipes-pr --> - [x] Not applicable <!-- TaskRadio recipes-pr --> Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
DariuszPorowski
had a problem deploying
to
publish-bicep
GitHub Actions
Error
DariuszPorowski
force-pushed
the
testify
branch
from
4e36a86 to
2b2f0c0
Compare
DariuszPorowski
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
DariuszPorowski
changed the title
DariuszPorowski
force-pushed
the
testify
branch
from
2b2f0c0 to
0818334
Compare
DariuszPorowski
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
DariuszPorowski
force-pushed
the
testify
branch
from
0818334 to
5ee264c
Compare
DariuszPorowski
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
DariuszPorowski
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
brooke-hamilton
approved these changes
Feb 6, 2026
DariuszPorowski
force-pushed
the
testify
branch
from
181c02a to
b583185
Compare
DariuszPorowski
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
…ration Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
…workflow Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
DariuszPorowski
force-pushed
the
testify
branch
from
b583185 to
6f22210
Compare
DariuszPorowski
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes a minor change to the
go.modfile, specifically by removing areplacedirective for thegithub.com/stretchr/testifydependency. This streamlines the module's dependency management.Type of change
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: